Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tokens list to display with hideTokensWithoutBalance setting #13007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jan 15, 2025

Description

PR to fix an issue with the tokenList showing the msg "You don't have any tokens" when popular networks is selected and the setting HideTokensWithoutBalance is enabled

Related issues

Fixes:

Manual testing steps

  1. click on account selector
  2. Create a new empty account
  3. Go to settings => General and and toggle hide tokens without balance setting
  4. go back to home page; and select popular network
  5. You should still see native tokens even with zero balance. Only ERC20 tokens should not be displayed when the setting is ON

Screenshots/Recordings

Before

image

After

Screen.Recording.2025-01-15.at.16.46.55.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner January 15, 2025 15:41
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4f8b3e4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d9e28c1-eda9-40df-9d8d-79dd47ac35d2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if this is the expected behavior, and it won't align with the behavior on extension.

I'm flagging this until we come to a decision with Product 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants