Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorganize stake button tests #13017

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Jan 15, 2025

Description

This moves the stake button tests from Tokens test to StakeButton.test.tsx for relevant code ownership.

This also adds a test to navigate to stake screen when on unsupported network.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This moves the stake button tests from Tokens test to StakeButton.test.tsx  for relevant code ownership.
This  also adds a test to navigate to stake screen when on unsupported network.
@amitabh94 amitabh94 requested review from a team as code owners January 15, 2025 21:17
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 added the No QA Needed Apply this label when your PR does not need any QA effort. label Jan 15, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.84%. Comparing base (faf5340) to head (33c2749).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13017   +/-   ##
=======================================
  Coverage   59.83%   59.84%           
=======================================
  Files        1873     1874    +1     
  Lines       42121    42143   +22     
  Branches     5473     5479    +6     
=======================================
+ Hits        25204    25221   +17     
- Misses      15235    15239    +4     
- Partials     1682     1683    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amitabh94 amitabh94 enabled auto-merge January 15, 2025 21:28
Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitabh94 amitabh94 added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 77438ce Jan 15, 2025
54 of 56 checks passed
@amitabh94 amitabh94 deleted the chore/organize-stake-tests branch January 15, 2025 21:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants