Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Extensions tutorial articles to sample articles #3327

Merged
merged 9 commits into from
Jan 14, 2025

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Dec 4, 2024

Rendered articles for review:

AB#54402190

@mikehoffms mikehoffms added the cat: extensions Extensions-related content. label Dec 4, 2024
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but let's remove the mention of popup.js where we discuss jQuery, since that file doesn't use jQuery.

Copy link

Learn Build status updates of commit b89be58:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/developer/index.yml ✅Succeeded View
microsoft-edge/devtools-guide-chromium/sources/index.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/sidebar.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/index.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/clone-a-repo-dbox-ghd.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/developermode-toggle.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extension-running.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extensions-icon.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extensions-popup-no-extensions.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extensions-popup-with-launch-icon.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extensions-popup.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/icon-png-toolbar.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/load-unpacked-icon.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/part1-badge1.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/part1-installed-extension.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/clone-a-repo-dbox-ghd.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/developermode-toggle.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/extensions-popup-no-extensions.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/load-unpacked-icon.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/open-the-extension.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/part2-installed-extension.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/part2-popupdialog.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/part2-showingimage.png ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit 6e95098 into main Jan 14, 2025
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/extension-samples branch January 14, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: extensions Extensions-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants