-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #9 Fix warnings #12
Changes from 25 commits
9f425d7
4db5abd
b10a756
a83bccf
1b02967
64a0cc8
bde1132
8d43090
8df5c09
0f9c1b4
1005054
3176940
fd7d8da
3990460
5f90d06
d404704
fd59e02
86f2643
9256b8b
e5906d8
19b3229
579544d
3d3685e
5dff5e4
b201427
a5c5c38
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
namespace Raygun.NetCore.Blazor.Server | ||
{ | ||
/// <summary> | ||
/// | ||
/// </summary> | ||
public class Class1 | ||
{ | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,12 +14,10 @@ internal record BrowserSpecs | |
{ | ||
#region Private Members | ||
|
||
private string calculatedBrowserVersion; | ||
private string calculatedBrowserName; | ||
private string calculatedOSVersion; | ||
private string deviceModel; | ||
private string deviceName; | ||
private string browserManufacturer; | ||
private string? _calculatedBrowserVersion; | ||
private string? _calculatedBrowserName; | ||
private string? _calculatedOSVersion; | ||
// private string? _browserManufacturer; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should delete this unless we intend to wire it up There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At one point I had intended to wire those up from the UserAgentHints, but then I discovered that the versioning at that level is a dictionary of multiple sets of values, including an extra key designed to throw off people doing things like this. So I believe I decided to return the whole array (minus the BS extra key) instead, which means those can be deleted. |
||
|
||
#endregion | ||
|
||
|
@@ -33,12 +31,12 @@ internal record BrowserSpecs | |
/// <summary> | ||
/// | ||
/// </summary> | ||
public string CalculatedBrowserName => calculatedBrowserName; | ||
public string? CalculatedBrowserName => _calculatedBrowserName; | ||
|
||
/// <summary> | ||
/// | ||
/// </summary> | ||
public string CalculatedBrowserVersion => calculatedBrowserVersion; | ||
public string? CalculatedBrowserVersion => _calculatedBrowserVersion; | ||
|
||
/// <summary> | ||
/// | ||
|
@@ -48,22 +46,22 @@ internal record BrowserSpecs | |
/// <summary> | ||
/// | ||
/// </summary> | ||
public string DeviceManufacturer { get; set; } | ||
public string? DeviceManufacturer { get; set; } | ||
|
||
/// <summary> | ||
/// | ||
/// </summary> | ||
public string DeviceModel => deviceModel; | ||
public string? DeviceModel { get; set; } | ||
|
||
/// <summary> | ||
/// | ||
/// </summary> | ||
public string DeviceName => deviceName; | ||
public string? DeviceName { get; set; } | ||
|
||
/// <summary> | ||
/// | ||
/// </summary> | ||
public decimal DeviceMemoryInGB { get; set; } | ||
public decimal DeviceMemoryInGb { get; set; } | ||
|
||
/// <summary> | ||
/// | ||
|
@@ -76,12 +74,12 @@ internal record BrowserSpecs | |
/// <summary> | ||
/// | ||
/// </summary> | ||
public string Locale { get; set; } | ||
public string? Locale { get; set; } | ||
|
||
/// <summary> | ||
/// | ||
/// </summary> | ||
public string CalculatedOSVersion => calculatedOSVersion; | ||
public string? CalculatedOSVersion => _calculatedOSVersion; | ||
|
||
/// <summary> | ||
/// | ||
|
@@ -91,7 +89,7 @@ internal record BrowserSpecs | |
/// <summary> | ||
/// | ||
/// </summary> | ||
public string Platform { get; set; } | ||
public string? Platform { get; set; } | ||
|
||
/// <summary> | ||
/// | ||
|
@@ -111,12 +109,12 @@ internal record BrowserSpecs | |
/// <summary> | ||
/// | ||
/// </summary> | ||
public BrowserUserAgentData UAHints { get; set; } | ||
public BrowserUserAgentData? UAHints { get; set; } | ||
|
||
/// <summary> | ||
/// | ||
/// </summary> | ||
public string UserAgent { get; set; } | ||
public string? UserAgent { get; set; } | ||
|
||
/// <summary> | ||
/// | ||
|
@@ -132,10 +130,10 @@ internal record BrowserSpecs | |
/// </summary> | ||
internal void ParseUserAgent() | ||
{ | ||
var result = HttpUserAgentParser.Parse(UserAgent); | ||
calculatedBrowserName = result.Name; | ||
calculatedBrowserVersion = result.Version; | ||
calculatedOSVersion = result.Platform.Value.Name; | ||
var result = HttpUserAgentParser.Parse(UserAgent!); | ||
_calculatedBrowserName = result.Name; | ||
_calculatedBrowserVersion = result.Version; | ||
_calculatedOSVersion = result.Platform?.Name; | ||
Console.WriteLine(result.MobileDeviceType); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine we'll just want to delete this class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the same, the
Raygun.Blazor.Server
question is addressed here: #22