ci: fix broken ci components #51

miquelbeltran · 2024-10-01T11:35:34Z

ci: fix broken ci components

Description 📝

Purpose: Currently some of the CI jobs won't run, attempt to fix them
Approach: Changes in GitHub CI files and formatting

Type of change'

Bug fix (non-breaking change which fixes an issue)

Updates

Fixes the existing CI build to be compatible with MAUI. See comments for details.

Test plan 🧪

CI should be all passing

Author to check 👓

Project and all contained modules builds successfully
Self-/dev-tested
Unit/UI/Automation/Integration tests provided where applicable
Code is written to standards
Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

Project and all contained modules builds successfully
Change has been dev-/reviewer-tested, where possible
Unit/UI/Automation/Integration tests provided where applicable
Code is written to standards
Appropriate documentation written (code comments, internal docs)

miquelbeltran · 2024-10-01T12:31:57Z

.github/workflows/dotnet-format.yml

@@ -17,5 +17,5 @@ jobs:

      - name: Format
        working-directory: ./src
-        run: dotnet format --verify-no-changes 
+        run: dotnet format --verify-no-changes --no-restore


Adding --no-restore fixes a runtime issue. The parameter:

Doesn't execute an implicit restore before formatting. Default is to do implicit restore.

miquelbeltran · 2024-10-01T12:32:27Z

.github/workflows/dotnet.yml

@@ -12,14 +12,24 @@ on:
 jobs:
  build:

-    runs-on: ubuntu-latest
+    runs-on: windows-latest


Switching to windows image so we can test MAUI build for Android, Windows, iOS and macOS

~~Does a Windows image (and Ubuntu before, too) build for iOS and macOS?~~

miquelbeltran · 2024-10-01T12:32:54Z

.github/workflows/dotnet.yml

+    - name: Setup JDK
+      uses: actions/setup-java@v4
+      with:
+        distribution: 'microsoft'
+        java-version: '17'
+    - name: Setup Android SDK
+      uses: android-actions/setup-android@v3


Setup Android build requirements

miquelbeltran · 2024-10-01T12:33:04Z

.github/workflows/dotnet.yml

+    - name: Restore workloads
+      working-directory: ./src
+      run: dotnet workload restore


Installs MAUI workloads

miquelbeltran · 2024-10-01T12:34:21Z

src/Raygun.Blazor.Maui/Raygun.Blazor.Maui.csproj

+        <TargetFrameworks>net8.0-android</TargetFrameworks>
        <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">
-            $(TargetFrameworks);net8.0-windows10.0.19041.0</TargetFrameworks>
+            $(TargetFrameworks);net8.0-ios;net8.0-maccatalyst;net8.0-windows10.0.19041.0</TargetFrameworks>
+        <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('osx'))">
+            $(TargetFrameworks);net8.0-ios;net8.0-maccatalyst</TargetFrameworks>


When the platform is Windows, it builds for Windows, Android, Mac and iOS. When the platform is osx (macos) it builds for Android, iOS and Mac. On the rest of platforms (basically Linux) it only builds for Android.

Same for the Sample project.

Ok, this answers my question above.

miquelbeltran · 2024-10-01T12:34:30Z

src/Raygun.Samples.Blazor.Maui/MauiProgram.cs

+            builder.Services.AddBlazorWebViewDeveloperTools();
+            builder.Logging.AddDebug();


Fixes formatting

sumitramanga · 2024-10-01T19:57:11Z

When viewing the Files Changed tab, there are some warnings to address, could you perhaps look into those. Or, if they're an Issue already, I'm happy with them being in a separate branch,

miquelbeltran · 2024-10-02T05:36:18Z

I'll address them in this branch @sumitramanga

miquelbeltran · 2024-10-02T09:02:57Z

@sumitramanga the warnings have been addressed now

TheRealAgentK · 2024-10-05T01:35:39Z

.github/workflows/dotnet.yml

@@ -12,14 +12,24 @@ on:
 jobs:
  build:

-    runs-on: ubuntu-latest
+    runs-on: windows-latest


~~Does a Windows image (and Ubuntu before, too) build for iOS and macOS?~~

TheRealAgentK · 2024-10-05T01:36:42Z

src/Raygun.Blazor.Maui/Raygun.Blazor.Maui.csproj

+        <TargetFrameworks>net8.0-android</TargetFrameworks>
        <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">
-            $(TargetFrameworks);net8.0-windows10.0.19041.0</TargetFrameworks>
+            $(TargetFrameworks);net8.0-ios;net8.0-maccatalyst;net8.0-windows10.0.19041.0</TargetFrameworks>
+        <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('osx'))">
+            $(TargetFrameworks);net8.0-ios;net8.0-maccatalyst</TargetFrameworks>


Ok, this answers my question above.

miquelbeltran · 2024-10-05T06:56:05Z

Yep, I tried to make it work on Ubuntu but compiling on Linux only works for Android MAUI apps (and only from CLI, not even in Rider). Windows VMs seem the best compromise as it can build for all 4 platforms.

miquelbeltran added 7 commits October 1, 2024 13:33

dotnet format

e483d12

add --no-restore option to avoid dotnet errors

705098e

restore workloads

c127f22

change CI to macos

52c7597

make os platform target depend on OS

dfe1452

setup Android for MAUI build

7b3cf5e

try windows

fa44cd8

miquelbeltran commented Oct 1, 2024

View reviewed changes

miquelbeltran marked this pull request as ready for review October 1, 2024 12:34

miquelbeltran requested review from TheRealAgentK, a team, PanosNB and sumitramanga and removed request for a team October 1, 2024 12:36

miquelbeltran added 2 commits October 2, 2024 10:34

add class summary

674044a

fix nullability requirement

23459a4

miquelbeltran mentioned this pull request Oct 2, 2024

perf: #31 use GeneratedRegex #50

Merged

11 tasks

TheRealAgentK approved these changes Oct 5, 2024

View reviewed changes

miquelbeltran merged commit 94d0e36 into main Oct 5, 2024
3 checks passed

miquelbeltran deleted the fix-ci branch October 5, 2024 06:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: fix broken ci components #51

ci: fix broken ci components #51

miquelbeltran commented Oct 1, 2024 •

edited

Loading

miquelbeltran Oct 1, 2024

miquelbeltran Oct 1, 2024 •

edited

Loading

TheRealAgentK Oct 5, 2024

miquelbeltran Oct 1, 2024

miquelbeltran Oct 1, 2024

miquelbeltran Oct 1, 2024

TheRealAgentK Oct 5, 2024

miquelbeltran Oct 1, 2024

sumitramanga commented Oct 1, 2024

miquelbeltran commented Oct 2, 2024

miquelbeltran commented Oct 2, 2024

TheRealAgentK Oct 5, 2024

TheRealAgentK Oct 5, 2024

miquelbeltran commented Oct 5, 2024

		builder.Services.AddBlazorWebViewDeveloperTools();
		builder.Logging.AddDebug();

ci: fix broken ci components #51

ci: fix broken ci components #51

Conversation

miquelbeltran commented Oct 1, 2024 • edited Loading