Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Portable Debug Data images #56

Merged
merged 11 commits into from
Nov 8, 2024
Merged

feat: Portable Debug Data images #56

merged 11 commits into from
Nov 8, 2024

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Oct 18, 2024 •
edited
Loading

feat: Portable Debug Data images

Description 📝

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

  • Implements providing the Portable Debug Data image references based on the Raygun4Net implementation.
  • They get attached in the error.images payload (see README changes for example)
  • Adds unit tests that verify the inclusion of stacktraces and the pdb images
  • Adds info about stacktraces in the README

Test plan 🧪

  • Tested on WebAssembly, Server and MAUI sample apps
  • Unit tests

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran miquelbeltran marked this pull request as ready for review October 21, 2024 08:45
@miquelbeltran miquelbeltran changed the title feat: PE Debug Data feat: Portable Debug Data images Oct 21, 2024
TheRealAgentK
TheRealAgentK approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a small text suggestion

README.md
```

This also works for exceptions originating in Blazor WebAssembly applications.
For example, this exception captured on WebAssembly:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...this exception was captured...

@miquelbeltran
Copy link
Contributor Author

I will wait until the PDB support for Blazor clients is available on raygun.com and test this end-to-end, we can keep this PR until then

ProRedCat
ProRedCat approved these changes Nov 4, 2024
View reviewed changes
Copy link

@ProRedCat ProRedCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for covering the case of Android Assembly Store

@miquelbeltran miquelbeltran merged commit c74d809 into main Nov 8, 2024
3 checks passed
@miquelbeltran miquelbeltran deleted the 15-PEDebug-data branch November 8, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProRedCat ProRedCat ProRedCat approved these changes

@TheRealAgentK TheRealAgentK TheRealAgentK approved these changes

@sumitramanga sumitramanga Awaiting requested review from sumitramanga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raygun.Blazor: PEDebug data populated where appropriate
3 participants
@miquelbeltran @TheRealAgentK @ProRedCat