Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Net 9.0 #62

Merged
merged 4 commits into from
Jan 7, 2025
Merged

feat: Support Net 9.0 #62

merged 4 commits into from
Jan 7, 2025

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Dec 20, 2024

feat: Support Net 9.0

Description 📝

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

To support both apps targetting Net 8.0 and Net 9.0, the following projects are set to target both frameworks, and define dependencies for either the two:

  • These projects support both targets net8.0 and net9.0:
    • Raygun.Blazor
    • Raygun.Blazor.Server
    • Raygun.Blazor.WebAssembly

As well, the corresponding samples and test projects have been updated

  • Sample projects migrated to use net9.0:
  • Raygun.Samples.Blazor.Server
  • Raygun.Samples.Blazor.WebAssembly
  • Test projects migrated to use net9.0:
    • Raygun.Tests.Blazor
    • Raygun.Tests.Blazor.Server

To align with Raygun 4 MAUI, the MAUI projects are still on net8.0:

  • These projects are still using net8.0 frameworks:
    • Raygun.Blazor.Maui uses net8.0-android, net8.0-ios etc.
    • Raygun.Samples.Blazor.Maui remains in net8.0

Test plan 🧪

  • Build and unit tests work
  • Run the sample projects

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran miquelbeltran marked this pull request as ready for review January 6, 2025 10:29
Comment on lines +47 to +51
<ItemGroup Condition="'$(TargetFramework)' == 'net9.0'">
<PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="[9.*, 10.0.0)" />
<PackageReference Include="Microsoft.Extensions.Http" Version="[9.*, 10.0.0)" />
<PackageReference Include="Microsoft.JSInterop" Version="[9.*, 10.0.0)" />
</ItemGroup>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency constraints depend on the target framework. When targeting net 9.0, versions can be from >= 9.0.0 to <10.0.0

Copy link

@ProRedCat ProRedCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@miquelbeltran miquelbeltran merged commit 0261d33 into main Jan 7, 2025
6 checks passed
@miquelbeltran miquelbeltran deleted the net9 branch January 7, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants