Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Issue and PR templates #8

Merged
merged 1 commit into from
Jul 17, 2024
Merged

chore: Issue and PR templates #8

merged 1 commit into from
Jul 17, 2024

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Jul 16, 2024 •
edited
Loading

chore: Issue and PR templates

Description 📝

  • Purpose: Adds issue and PR template
  • Approach: Copied over from raygun4java, with small tweaks

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

  • Copied template files from raygun4java.
  • Modified the parts that refer to java versions or libraries.

Screenshots 📷

  • None

Test plan 🧪

  • None

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran
Copy link
Contributor Author

Ignore the failing CI, that is addressed in #6

@miquelbeltran miquelbeltran requested review from a team, nikz, TheRealAgentK and sumitramanga and removed request for a team July 16, 2024 07:22
TheRealAgentK
TheRealAgentK approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miquelbeltran miquelbeltran merged commit 3ba8171 into main Jul 17, 2024
1 check failed
@miquelbeltran miquelbeltran deleted the templates branch July 17, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAgentK TheRealAgentK TheRealAgentK approved these changes

@nikz nikz Awaiting requested review from nikz nikz was automatically assigned from MindscapeHQ/kai-miquel-and-friends

@sumitramanga sumitramanga Awaiting requested review from sumitramanga sumitramanga was automatically assigned from MindscapeHQ/kai-miquel-and-friends

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miquelbeltran @TheRealAgentK