feat: flex - overlapping_zone_and_pickup_drop_off_window
#1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cka-y
changed the title
overlapping_zone_and_pickup_drop_off_window
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 7e68a93 📊 Notices ComparisonNew Errors (2 out of 1788 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1788 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1788 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1788 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1788 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
davidgamez
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses overlapping geometries and pickup/drop off windows.
Expected Behavior
The pull request ensures overlapping geometries are flagged and appropriate notices are generated during validation. Below are the detailed results for the relevant feeds determined from the :
1. For mdb-1195
The validation identifies overlapping geometries between
area_505andarea_506.2. For mdb-2160
The validation identifies overlapping geometries between
area_1082andarea_897.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything