Review of PR

ModelOriented · Jul 7, 2024 · 2278089 · 2278089
1 parent f003dc3
commit 2278089
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R/utils_calculate.R b/R/utils_calculate.R
@@ -151,7 +151,7 @@ gwColMeans <- function(x, g = NULL, w = NULL) {
   }
 
   # Now the interesting case
-  if (!is.vector(x) || !is.matrix(x)) {
+  if (!is.vector(x) && !is.matrix(x)) {
     x <- as.matrix(x)
   }
   if (is.null(w)) {

diff --git a/R/utils_input.R b/R/utils_input.R
@@ -99,7 +99,7 @@ prepare_w <- function(w, X) {
 #'   or column names in `X`.
 #' @param X Matrix-like.
 #' 
-#' @returns A list with "y" (vector, matrix) and "y_names" (if `y`
+#' @returns A list with "y" (vector, matrix, or factor) and "y_names" (if `y`
 #'   was passed as column names).
 prepare_y <- function(y, X) {
   if (NROW(y) < nrow(X) && all(y %in% colnames(X))) {