Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub: Code quality, enhancments and better maintainability #23

Open
wants to merge 15 commits into
base: staging
Choose a base branch
from
Open

Hub: Code quality, enhancments and better maintainability #23

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6c4f0df
version number prints at server startup instead of ${plugin.version} …
palsmo Dec 31, 2024
d28121f
Code quality, enhancments and better maintainability
palsmo Jan 1, 2025
cff0dfd
join message should not be delayed
palsmo Jan 1, 2025
9a23f5b
Extracted welcome sounds into its own class & wrote a friendly welcom…
palsmo Jan 1, 2025
f387bdd
Utility class should not be instantiated
palsmo Jan 1, 2025
841390b
Better exception message.
palsmo Jan 1, 2025
6388477
Fixed good integration with PremiumVanish, server will have uniform j…
palsmo Jan 2, 2025
f19ee38
Uncomment dependencies
palsmo Jan 2, 2025
b41d678
Using 'isConnected()' is most appropriate here, would correcly solve …
palsmo Jan 2, 2025
0c15e01
Added check for if the firework would have been despawned etc. before…
palsmo Jan 2, 2025
82eb9c6
Moved fields to top of class, as is standard.
palsmo Jan 2, 2025
f2649af
Small simplifications, added checks for functions that require their …
palsmo Jan 3, 2025
98183d0
Fixed proper integration 'config.yml' + spilled out to a few other fi…
palsmo Jan 5, 2025
0440e83
Removed debug code accidentally left behind
palsmo Jan 5, 2025
a07194f
Proper mirroring of resource files, new configs 'slot_hub_compass' & …
palsmo Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions zander-hub/src/main/java/org/modularsoft/zander/hub/events/HubPlayerJoin.java
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make the compass slot and such a configuration option in the config yml instead of setting it static.

Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class HubPlayerJoin implements Listener {
// Misc settings
private static final boolean TEST_ALWAYS_FIRST_JOIN = false; // * default false
private static final int NAV_COMPASS_SLOT = 4;
private static final long ROUTINE_PLAYER_JOINED_DELAY = (long) (1.5f * 20);
private static final long ROUTINE_PLAYER_JOINED_DELAY = (long) (1.2f * 20);

// Firework settings
private static final double FIREWORK_GROUND_HEIGHT = 3; // blocks
Expand Down Expand Up @@ -107,16 +107,16 @@ public void onPlayerLogin(PlayerLoginEvent event) {
/// Best used for initial world interactions (player world state changes etc).
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event) {
event.joinMessage(null); // * suppress default
Player player = event.getPlayer();
event.joinMessage(null); // * suppress default
chatJoinMessage(player);
setInitialState(player);
Bukkit.getScheduler().runTaskLater(plugin, () -> {
// * bukkit uses 'world/playerdata' dir for tracking
if (!player.hasPlayedBefore() || TEST_ALWAYS_FIRST_JOIN) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

player.hasPlayedBefore should always return a Boolean, not sure why the secondary test is present?

chatWelcomeMessage(player);
spawnWelcomeFirework(player);
}
chatJoinMessage(player);
playWelcomeSound(player);
}, ROUTINE_PLAYER_JOINED_DELAY);
}
Expand Down