Locale-based calendar week format #10360
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the calendar is hardcoded to use sunday-saturday week format, which is not used worldwide. I suggest to use
calendar
module which in turn uses user's locale to determine first day of week.After some testing it seems that it's enough just to set
DAY_NAMES
appropriately and update a constant in_setupDayButtons
for it to seemingly work absolutely the same with the different week format.This PR only adds monday-sunday week format (e.g. used in all of the Europe, Russia, and many other countries); in case
firstweekday
returns neither0
nor6
the calendar remains sunday-saturday.