Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update BpyBuild to 0.5 #639

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Conversation

StandingPadAnimations
Copy link
Collaborator

@StandingPadAnimations StandingPadAnimations commented Oct 11, 2024

This updates the toolchain to use BpyBuild 0.5, and with it some improvements have been made to our config and actions:

  • BpyBuild config now uses the new version shorthands introduced in 0.4.X (which we didn't use to avoid breakage)
  • Our override extension action now takes advantage of lib_bpybuild_ext to perform manifest verification and compatibility checks in the MCprep code. In addition, the action now does a search and replace in __init__.py for bl_info when building as an extension, which A. removes the need for a patch that constantly breaks and B. means the extension build will work out of the box
  • MCprep now builds both an extension and legacy build. Although we'll likely only continue to offer the legacy build for the foreseeable future, it's nice to build both just for wider coverage.

This being a major release, there are definitely some bugs I've caught while working on this update (which will be fixed in the coming weeks), but nothing that can't be worked around (they're all "out of the box" bugs so to speak, we can easily work around them).

Edit October 11th, 2024: Pushed some bug fixes on Moo-Ack-Productions/bpy-build#21

Copy link
Member

@TheDuckCow TheDuckCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as a comment initially, will test this again once we have the final bpy-build update ready (presuming the other recent PRs there should included right?)

bpy-build.yaml Outdated Show resolved Hide resolved
@TheDuckCow TheDuckCow self-requested a review October 11, 2024 18:07
Co-authored-by: Patrick W. Crawford <[email protected]>
@StandingPadAnimations
Copy link
Collaborator Author

@TheDuckCow tagging you to let you know that this is ready for further review. BpyBuild 0.5.1 is also out, which fixes the main issues I caught while working on this (though BpyBuild 0.5 also works fine with this config, so I don't think it's necessary to raise the minimum)

@StandingPadAnimations
Copy link
Collaborator Author

StandingPadAnimations commented Oct 17, 2024

I do have a few questions though:

  • Assuming we're only providing legacy builds for the foreseeable future, is the updated config (where we build both an extension and legacy addon) fine as is, or would it be preferable to only build legacy builds?
  • If we build both an extension and legacy addon, would it be preferable to have some slight name change for the extension build (again assuming we're only providing legacy builds in the long run), maybe something like "MCprep Extension Build"?
  • Slightly off-topic, but I noticed it was suggested that the minimum be changed to 2.83, are we planning on dropping 2.8 to 2.82 with the update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants