-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update BpyBuild to 0.5 #639
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Mahid Sheikh <[email protected]>
Signed-off-by: Mahid Sheikh <[email protected]>
Signed-off-by: Mahid Sheikh <[email protected]>
Signed-off-by: Mahid Sheikh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving as a comment initially, will test this again once we have the final bpy-build update ready (presuming the other recent PRs there should included right?)
Co-authored-by: Patrick W. Crawford <[email protected]>
@TheDuckCow tagging you to let you know that this is ready for further review. BpyBuild 0.5.1 is also out, which fixes the main issues I caught while working on this (though BpyBuild 0.5 also works fine with this config, so I don't think it's necessary to raise the minimum) |
I do have a few questions though:
|
This updates the toolchain to use BpyBuild 0.5, and with it some improvements have been made to our config and actions:
extension
action now takes advantage oflib_bpybuild_ext
to perform manifest verification and compatibility checks in the MCprep code. In addition, the action now does a search and replace in__init__.py
forbl_info
when building as an extension, which A. removes the need for a patch that constantly breaks and B. means the extension build will work out of the boxThis being a major release, there are definitely some bugs I've caught while working on this update (which will be fixed in the coming weeks), but nothing that can't be worked around (they're all "out of the box" bugs so to speak, we can easily work around them).
Edit October 11th, 2024: Pushed some bug fixes on Moo-Ack-Productions/bpy-build#21