Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge staging into prod post-QA #20

Merged
merged 18 commits into from
Jun 6, 2024
Merged

Merge staging into prod post-QA #20

merged 18 commits into from
Jun 6, 2024

Conversation

sjwmoveon
Copy link

@sjwmoveon sjwmoveon commented Jun 6, 2024

Fixes #14 and StateVoicesNational#2366

Description

Adds a dynamic replies feature.

When exporting data, two links show up with no space between them, causing them to look like one link. Added line breaks between the export links to eliminate confusion.
image

Over 300 lines because that was the minimum needed for the dynamic replies feature.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

sjwmoveon and others added 18 commits May 3, 2024 13:31
Generates a special link used to reassign replies.  Known bugs: replies can be reassigned indefinitely because the `updated_at` field in `campaign_contact` does not actually update on reassignment.
Update campaign_contact.updated_at on change
…using the joinToken value

Also remove an unnecessary import and fix a comment
SonarCloud doesn't like raw http links, preferring https.  In this case the link should never be used so it makes no difference to switch to https.
Merge dynamic replies feature into staging branch
Add line breaks to export links [WIP]
@sjwmoveon sjwmoveon requested a review from technicalex June 6, 2024 16:13
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjwmoveon sjwmoveon merged commit bcaf4d7 into moveon-prod Jun 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants