forked from StateVoicesNational/Spoke
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge staging into prod post-QA #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generates a special link used to reassign replies. Known bugs: replies can be reassigned indefinitely because the `updated_at` field in `campaign_contact` does not actually update on reassignment.
Update campaign_contact.updated_at on change
…using the joinToken value Also remove an unnecessary import and fix a comment
Add dynamic replies feature
SonarCloud doesn't like raw http links, preferring https. In this case the link should never be used so it makes no difference to switch to https.
Fix SonarCloud alert
Merge prod into staging
Merge dynamic replies feature into staging branch
Add line breaks to export links [WIP]
Quality Gate passedIssues Measures |
technicalex
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14 and StateVoicesNational#2366
Description
Adds a dynamic replies feature.
When exporting data, two links show up with no space between them, causing them to look like one link. Added line breaks between the export links to eliminate confusion.
Over 300 lines because that was the minimum needed for the dynamic replies feature.
Checklist: