Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documenting histograms from Generators to an accompanying analyzer module #1352

Open
kutschke opened this issue Oct 4, 2024 · 3 comments

Comments

@kutschke
Copy link
Collaborator

kutschke commented Oct 4, 2024

I the early days of Mu2e we wrote event generator modules to include histotgrams that document the generator's actions. We now prefer separate modules - a clean generator module and an accompanying analyzer module. The reason is that this makes it possible to run just the analyzer module and point it at an existing data product.

There are some event generators that still are organized the old way. One example is:

https://github.com/Mu2e/Offline/blob/main/EventGenerator/src/RPCGun_module.cc

As I discover more I will edit this comment to add them (and to mark then as resolved when they are resolved ).

@kutschke kutschke mentioned this issue Oct 4, 2024
@sophiemiddleton
Copy link
Contributor

Hi Rob, I believe we have generic plotting module: https://github.com/Mu2e/Offline/blob/main/EventGenerator/src/GeneratorPlots_module.cc . Perhaps this can be re-purposed for the RPC too.

@kutschke
Copy link
Collaborator Author

kutschke commented Oct 4, 2024

I think that will work. It's an extra step to make plots from the TTree but that's easy to do and more flexible that making plots in code. Please remove the histograms from RPCGun_modules. I will merge #1341 now and you can start a new PR to make this change.

@sophiemiddleton
Copy link
Contributor

Thanks, I will put in another PR soon with the plots removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants