pions

[sophiemiddleton]

pion filters for RPC

[FNALbuild]

Hi @sophiemiddleton,
You have proposed changes to files in these packages:

• EventGenerator

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 7749c0d: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

[sophiemiddleton]

Still need to do some work on the filter to tidy it up

[FNALbuild]

☀️ The build tests passed at 7749c0d.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged 7749c0d at 38f72f8
build (prof)	✅	Log file. Build time: 04 min 13 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 2 files
clang-tidy	🔶	0 errors 185 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 7749c0d after being merged into the base branch at 38f72f8.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[kutschke]

Please look through the code and fix other instances of abs to std::abs.

[sophiemiddleton]

thanks, I found two other instances, now fixed

[sophiemiddleton]

@FNALbuild run build test

[FNALbuild]

⌛ The following tests have been triggered for bcd4eab: build (Build queue is empty)

[FNALbuild]

☀️ The build tests passed at bcd4eab.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged bcd4eab at 38f72f8
build (prof)	✅	Log file. Build time: 08 min 30 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 2 files
clang-tidy	🔶	0 errors 180 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at bcd4eab after being merged into the base branch at 38f72f8.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[sophiemiddleton]

Any more comments on this, I would like to begin making pion samples this week

[kutschke]

For a future PR, please split RPCGun_module into a generator, without histograms, and an analyzer that makes histograms. In the very early days we encouraged a single module that does both but we changed our minds some years ago and we want to move everything in the new direction. SInce I was not available to pay attention to PRs for so long, I won't insist on it now.

Added issue #1352 to address this.

[kutschke]

@FNALbuild run build test

[FNALbuild]

⌛ The following tests have been triggered for bcd4eab: build (Build queue is empty)

[FNALbuild]

☀️ The build tests passed at bcd4eab.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged bcd4eab at 5eb44d8
build (prof)	✅	Log file. Build time: 04 min 14 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 2 files
clang-tidy	🔶	0 errors 180 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at bcd4eab after being merged into the base branch at 5eb44d8.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[kutschke]

This PR has no coverage in the nightly validation - as best I can tell it affects only JobConfig/beam/POT_infinitepion.fcl . The oustanding request will be covered in Issue #1352 . Merging now.