-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Templates to .NET 9 & MudBlazor v8 #482
Conversation
src/mudblazor/MudBlazor.Template/Components/Account/Pages/ResetPasswordConfirmation.razor
Show resolved
Hide resolved
src/mudblazor/MudBlazor.Template/Components/Account/Pages/_Imports.razor
Show resolved
Hide resolved
Was a little mistake to give the main branch instead of the tag 9.0, it seems the main is on two commits a head, but luckily it seems only the tempalate.json is different with the net.10, so here is the correct one for .net9. |
The rest seems to be the same |
You're totally right! That's a relief that only the template is different; I will get that sync'ed today then. |
I added net9 to the build system, feel free to update the branch |
…h. Will finish testing tonight.
Somehow it still fails to build in CI, tho it's fine locally via the nuke-build. Not sure why it still thinks net8 is installed. I will look at it tmr, too tired for it today. |
Ok, I've finished testing all template projects and have verified that the new auth in .NET 9 is working as expected. I've restored the original Welcome message, and I think we're in good shape to review! |
I will review and test this on weekends. I'm also guessing that we will merge this once the v8 is out? |
Thanks for the update. Can you please also enable it to install with the dotnet new install MudBlazor.Templates command? Also README.md needs to be updated to show .NET 9. |
Hi guys! May I ask, what is the approximate time to merge? |
When will you be publishing the .net9 template? |
As I said, when MudBlazor v8 will be released (this month), they will be bundled together. |
@ScarletKuro thank you for that clarification. |
Yes, exactly. |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
V8 is out, but it will some time to roll out the template, as we depend on external dependency |
Quality Gate passedIssues Measures |
New templates are out
In future there will further improvements to that template, for example @Anu6is has some solution for the drawer in static SSR. |
Its awesome. Thanks a lot!!! |
Description
Resolves: #481
This update upgrades MudBlazor templates to match the latest ASP.NET Core Blazor Project templates. Changes include a reduced amount of code for auth pages, a better way to detect render modes, and an upgrade to .NET 9. Overall, however, files are largely the same.
Changes were made by performing the following steps:
MudBlazor.Templates
repo (clone link)aspnetcore
repo (clone link)net9
branch inaspnetcore
aspnetcore\src\ProjectTemplates\Web.ProjectTemplates\content\BlazorWeb-CSharp\BlazorWeb-CSharp
in BeyondCompare and setting the local code folders via Set Base FoldersSpecial thanks once again to @Anu6is for the MudBlazor.Static library for the Account Management pages.
Using BeyondCompare to Update Templates
How Has This Been Tested?
This was tested by:
.\InstallAndBuildAllTemplates.ps1
PowerShell scriptType of Changes
Checklist
dev
).