[docs] [sdk] Update e2e counter docs and template #20044
Conversation
…ystenLabs#20043)" This reverts commit 4df3956.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
github-actions
bot
added
the
Type: Documentation
|
Dan already knows, but doc changes lg |
dantheman8300
changed the title
| </Container> | ||
| ); | ||
| const { mutate: signAndExecute } = useSignAndExecuteTransaction(); | ||
| const [waitingForTxn, setWaitingForTxn] = useState(false); |
There was a problem hiding this comment.
The useSignAndExecuteTransaction already has state for this, and returns the following properties that can be used:
isIdle, isPending, isSuccess, isError, and status.
You probably want isPending
There was a problem hiding this comment.
Tried this. The issue is that waitingForTxn is true until after the transaction is waited for. isPending becomes false after the transaction is executed, not waited for though.
with waitingForTxn
Screen.Recording.2024-11-01.at.9.32.48.AM.mov
with isPending
Screen.Recording.2024-11-01.at.9.34.10.AM.mov
There was a problem hiding this comment.
isSuccess should work though
There was a problem hiding this comment.
I ended up using isSuccess and isPending since when I just used isSuccess, the spinner won't show after the button is pressed but before the user accepts the transaction.
| if (objectId) { | ||
| onCreated(objectId); | ||
| } | ||
| onSuccess: ({ digest }) => { |
There was a problem hiding this comment.
If you make this an async function, and await the waitForTransaction, you should be able to uses the isPending status from the useSignAndExecuteTransaction hook, rather than tracking your own state
There was a problem hiding this comment.
Addressed. Had to use isSuccess as well as isPending. Mentioned in previous comment
sdk/create-dapp/templates/react-e2e-counter/src/CreateCounter.tsx
Outdated
Show resolved
Hide resolved
…AndExecuteTransaction" This reverts commit cf6a029.
dantheman8300
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dantheman8300
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
ronny-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
ronny-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This PR fixes an issue with the e2e counter template where sometimes the data is refetched too soon after a transaction is executed.