rest: add support for protobuf to remaining endpoints that support a binary content type #20096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the ListFullCheckpoint api as its a bit too heavy-weight and instead we'll look to introduce a streaming api in the future.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
…saction endpoints
|
After talking with @wlmyng I'll add a commit on top of this to have the client request BCS data till this rolls out to all networks |
Revert the client change to request protobuf as a response type, and instead request bcs, because the support for protobuf hasn't rolled out to other networks yet.
wlmyng
approved these changes
Oct 31, 2024
| .into_inner(); | ||
| proto.try_into().map_err(Into::into) | ||
| self.inner.bcs(request).await.map(Response::into_inner) | ||
| // let proto = self |
| @@ -337,6 +337,36 @@ impl TryFrom<&UserSignature> for sui_types::signature::GenericSignature { | |||
| } | |||
| } | |||
|
|
|||
| // | |||
There was a problem hiding this comment.
Is this file translations between various types
sadhansood
approved these changes
Oct 31, 2024
Yeah, that and while I think these protos are a good start I think it may be good to sit on them for a short period of time (a week or two) to make sure there aren't any other changes we want to make before we can't trivially tweak them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.