indexer alt: integrate tempDB #20115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
8dd1bac to
e010f7e
Compare
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
e010f7e to
9c165ae
Compare
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
9c165ae to
bec36b2
Compare
gegaowp
commented
Oct 31, 2024
crates/sui-indexer-alt/Cargo.toml
Outdated
| @@ -25,6 +25,7 @@ prometheus.workspace = true | |||
| reqwest.workspace = true | |||
| serde.workspace = true | |||
| telemetry-subscribers.workspace = true | |||
| tempfile.workspace = true | |||
There was a problem hiding this comment.
moved here for TempDB, which is better without #[cfg(test)]
amnn
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Looks good, thanks @gegaowp -- main thing I'd like to see is whether we can avoid duplicating the config defaults (cc @bmwill in case you have any tricks here...), otherwise the other main comment is about file order and position for tempdb.rs, the file structure we use in sui-indexer-alt is:
- imports
- exports
- modules
- consts
- types
- impl blocks
- trait impl blocks (more generic trait impls go last)
- free functions
- tests
In each section elements are ordered in decreasing order of visibility (pub, pub(crate), ..., to private).
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
30d61de to
e66ce7d
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
e66ce7d to
634c691
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
634c691 to
42f5180
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
revised pr and resolved comments except the duplicate default value. |
bmwill
reviewed
Oct 31, 2024
bmwill
reviewed
Oct 31, 2024
bmwill
reviewed
Oct 31, 2024
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
fcece3b to
7d78581
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
7d78581 to
420ceda
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
420ceda to
ca43ec7
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
ca43ec7 to
1a85800
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
1a85800 to
42b4f02
Compare
gegaowp
force-pushed
the
tempdb-idx-alt
branch
from
42b4f02 to
d4b5e07
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
pushed a commit
that referenced
this pull request
Nov 5, 2024
## Description title to unblock committer related tests including some test utils for those tests. ## Test plan - modified smoketest of tempdb - added test for reset_database without running migrations --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
title to unblock committer related tests including some test utils for those tests.
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.