Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indexer-alt] Remove coin balance bucket pruner #20805

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Jan 7, 2025

Description

This PR reimplements the coin balance bucket pruner using proper pruner instead of a pipeline.
This is the last pipeline that uses consistency layer. So we also get rid of all the related implementation code for it.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@lxfind lxfind marked this pull request as ready for review January 7, 2025 16:51
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 7:38pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 7:38pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 7:38pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 7:38pm

@lxfind lxfind force-pushed the xun/indexer-alt-remove-coin-balance-bucket-pruner branch from 0ed3b65 to b632f95 Compare January 7, 2025 17:00
@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env January 7, 2025 17:00 — with GitHub Actions Inactive
@lxfind lxfind requested review from amnn, wlmyng, emmazzz and gegaowp January 7, 2025 17:01
Copy link
Contributor

@wlmyng wlmyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need to update fn process for CoinBalanceBuckets handler?

@lxfind
Copy link
Contributor Author

lxfind commented Jan 7, 2025

Good catch!

Copy link
Contributor

@wlmyng wlmyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lxfind lxfind merged commit 56fdf0b into main Jan 9, 2025
52 checks passed
@lxfind lxfind deleted the xun/indexer-alt-remove-coin-balance-bucket-pruner branch January 9, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants