-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[consensus] logging and metrics improvements #20807
Merged
Merged
+72
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 7, 2025 17:23 — with
GitHub Actions
Inactive
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 7, 2025 17:28 — with
GitHub Actions
Inactive
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 7, 2025 20:03 — with
GitHub Actions
Inactive
arun-koshy
approved these changes
Jan 7, 2025
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 8, 2025 01:26 — with
GitHub Actions
Inactive
mwtian
added a commit
that referenced
this pull request
Jan 9, 2025
## Description - Include peer hostname in round prober errors. - Fix block proposal interval metric. - Log missing blocks and peers fetched from in info. - Add `synchronizer_current_missing_blocks_by_authority` metric. ## Test plan CI PT --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
mwtian
added a commit
that referenced
this pull request
Jan 9, 2025
## Description - Include peer hostname in round prober errors. - Fix block proposal interval metric. - Log missing blocks and peers fetched from in info. - Add `synchronizer_current_missing_blocks_by_authority` metric. ## Test plan CI PT --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
synchronizer_current_missing_blocks_by_authority
metric.Test plan
CI
PT
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.