Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus] logging and metrics improvements #20807

Merged
merged 6 commits into from
Jan 8, 2025
Merged

[consensus] logging and metrics improvements #20807

merged 6 commits into from
Jan 8, 2025

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented Jan 7, 2025

Description

  • Include peer hostname in round prober errors.
  • Fix block proposal interval metric.
  • Log missing blocks and peers fetched from in info.
  • Add synchronizer_current_missing_blocks_by_authority metric.

Test plan

CI
PT


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@mwtian mwtian requested a review from a team as a code owner January 7, 2025 17:23
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 1:27am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:27am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:27am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:27am

@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 8, 2025 01:26 — with GitHub Actions Inactive
@mwtian mwtian enabled auto-merge (squash) January 8, 2025 01:26
@mwtian mwtian merged commit 94d58c4 into main Jan 8, 2025
52 checks passed
@mwtian mwtian deleted the tmw/fix-logs branch January 8, 2025 01:57
mwtian added a commit that referenced this pull request Jan 9, 2025
## Description 

- Include peer hostname in round prober errors.
- Fix block proposal interval metric.
- Log missing blocks and peers fetched from in info.
- Add `synchronizer_current_missing_blocks_by_authority` metric.

## Test plan 

CI
PT

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
mwtian added a commit that referenced this pull request Jan 9, 2025
## Description 

- Include peer hostname in round prober errors.
- Fix block proposal interval metric.
- Log missing blocks and peers fetched from in info.
- Add `synchronizer_current_missing_blocks_by_authority` metric.

## Test plan 

CI
PT

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants