Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: github action to check pull request files for svn info #804

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hkershaw-brown
Copy link
Member

Description:

Github action to check for svn detritus in any changed files in the pull request.
Only checks changed and new files, primary goal is to prevent people putting new files with svn info, secondary goal is to remove svn info as we find it while the file is under review.

Fixes issue

Partial fix for #802

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Github action

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
Ran the action on pull requests on my fork of DART
Ran the bash though shellcheck

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown force-pushed the lint_for_svn branch 2 times, most recently from 0224a3e to 719eaca Compare January 23, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant