Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to read MLE Frontal-Length Scale via file #331

Open
wants to merge 4 commits into
base: dev/ncar
Choose a base branch
from

Conversation

gustavo-marques
Copy link
Collaborator

Introduced the MLE_FRONT_LENGTH_FROM_FILE parameter to allow specifying a spatially and temporally varying MLE frontal-length scale via netCDF file.

A new diagnostic, mle_fl, has also been added. mle_fl is the frontal-length scale used in the mixed-layer restratification parameterization.

This PR does not change answers.

Introduced the `MLE_FRONT_LENGTH_FROM_FILE` parameter to allow specifying
a spatially and temporally varying MLE frontal-length scale via netCDF file.

Also added a new diagnostic, `mle_fl`, to save the frontal-length scale used
in the mixed-layer restratification parameterization.
Ensure mle_fl_2d(:,:) is set to 0.0 each time the subroutine
mixedlayer_restrat_OM4 is called. This prevents NaN values from
occurring.
Introduced a frontal length scale at velocity points and added
a condition to check for a zero denominator before performing
the division.
@gustavo-marques
Copy link
Collaborator Author

Solves ESCOMP/MOM_interface#218

@alperaltuntas
Copy link
Member

I am not exactly sure why, but merging this PR leads to the following error when with the gnu debug test case:

At line 806 of file /glade/work/altuntas/cesm.sandboxes/cesm3_0_alpha05c.sbx/components/mom/MOM6/pkg/CVMix-src/src/shared/cvmix_kpp.F90
Fortran runtime error: Index '0' of dimension 1 of array 'zt' below lower bound of 1

Test case dir: /glade/derecho/scratch/altuntas/cesm.tests/pr_mom/30alpha05c/SMS_D_Ld2.T62_t232.G.derecho_gnu.C.20250109_093409_sebvbj

@gustavo-marques
Copy link
Collaborator Author

Is this including yesterday's PR #332?

@alperaltuntas
Copy link
Member

Is this including yesterday's PR #332?

It fails with and without that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants