-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand var compatibility test for active attribute #525
Expand var compatibility test for active attribute #525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for making these changes.
Please fill in the PR header. I'm not understanding how this addresses #432. |
@gold2718 Not sure what else to put in there? (There's a code snippet of the correctly autogenerated code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me why the autogenerated code has the if (.true.)
blocks?
test/var_compatibility_test/run_test
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not modified in this PR but can you change defdir
to be something unique? I like to run all the tests with --cleanup NEVER
to compare code and currently, this test overwrites the capgen test.
I'm not sure why those lines are in there. Maybe @climbfuji knows their history and/or importance They are unnecessary and make the code tedious to look at. |
The |
@climbfuji This makes sense. Thanks for the history. And adios extra lines! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - thanks @dustinswales
@dustinswales Can you confirm that after removing the |
This PR expands the existing var_compatibility_test to test the functionality of the "active" attribute.
User interface changes? No
Addresses #432
Screenshot of autogenerated code: