Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency versions for v1.4.5 #208

Merged
merged 9 commits into from
Oct 23, 2023

Conversation

Xanonymous-GitHub
Copy link
Member

@Xanonymous-GitHub Xanonymous-GitHub commented Oct 23, 2023

Description

Note
This PR is optional for merging.

This PR overall upgrade both aos and ios dependencies and some of their environment configs.

  • Pub dependencies
    It aims for dealing with some potential issues existing in outdated dependencies.
    However, we may not able to update all dep's version since some of them require Dart v3

It seems that there's no any breaking changes among those upgraded deps.

  • AOS side

    • The major kotlin version has been upgraded to 1.9.10.
    • The required dependencies defined in gradle files has been upgraded. Most of them are firebase-related deps, which seems necessary to be upgraded since the changes made in pubspec.yml.
    • A namespace field has been added into android block in for fitting with the upcoming new gradle version (v8.x). This behavior tries to prevent any un-recognizable issues due to environment changes.
  • iOS side

    • Since the new iOS 17 and Xcode version has released, this PR also does some operations to migrate project to fit with Xcode 15 and iOS 17.
      • The ENABLE_USER_SCRIPT_SANDBOXING has been disabled due to errors outputs by flutter.
    • All cocoapods deps upgraded, which changes the lock file simultaneously.

This PR also patches the security issue: CVE-2023-39139

Implementation

  • List the changes made in this PR.
  • Mention any breaking changes.

Testing Instructions

Testing this pr's changes may rely on what dependencies has updated.
Here are some possible paths to test those changes:

  • Open the information system on the other tab of the app. See if we can still browse normally in the school's information system without asking login again.
  • Download a file from ischool, to see if the notification can be shown normally.
  • Clean install the app on AOS API 33+ device, and open the app, then go to Downloads page to see if it will ask permissions normally. Then, after approving all required permissions, try to download a file form ischool and open that downloaded file to see if these steps works.

Finally consider trigger a release build to see if there's any error. (under appropriate environment)

  • Describe the steps for reviewing the changes.
  • List down manual tests that need to be performed to validate the changes.

Additional Notes

This PR is opened by experience. There's actually no any rapid requirement to do these change

@Xanonymous-GitHub Xanonymous-GitHub added this to the 1.4.5 milestone Oct 23, 2023
@Xanonymous-GitHub Xanonymous-GitHub self-assigned this Oct 23, 2023
@Xanonymous-GitHub Xanonymous-GitHub changed the base branch from master to release/1.4.5 October 23, 2023 12:47
@ntut-xuan ntut-xuan self-requested a review October 23, 2023 17:40
@ntut-xuan ntut-xuan merged commit 55f2abc into release/1.4.5 Oct 23, 2023
4 checks passed
@ntut-xuan ntut-xuan deleted the upgrade-dependency-versions branch October 23, 2023 17:40
ntut-xuan added a commit that referenced this pull request Oct 24, 2023
* Chore: change version number and build number on pubspec.yaml

* Upgrade dependency versions for v1.4.5 (#208)

* chore: 🤖 update outdated dependency version numbers

* chore: 🤖 mark un-upgradable dependencies

* chore: 🤖 upgrade lock file

* chore: 🤖 add namespace to gradle module for upcoming gradle ver

* chore: 🤖 upgrade expected kotlin version

* chore: 🤖 upgrade android native dependencies versions

* chore: 🤖 upgrade to Xcode v15

* chore: 🤖 update pre-build firebase target version

* chore: 🤖 upgrade ios pod lockfile version

* Chore: Press the number of the version

---------

Co-authored-by: Tien Yu Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants