Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修復「讀取學生列表時出現大量延遲」的問題 #231

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

ntut-xuan
Copy link
Collaborator

Description

在這個 PR 中,我修復了讀取學生列表時出現大量延遲的問題,並且提升了 UI 的流暢度。

目前確定似乎是無意進行了兩次的讀取,並且缺失了讀取學生的 Modal,在這個 PR 上補齊。

How to Review it?

  • 確認無短暫延遲

@ntut-xuan ntut-xuan requested a review from rileychh February 29, 2024 17:30
Copy link
Collaborator

@James-Lu-none James-Lu-none left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@umeow0716 umeow0716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intl_zh_TW.arb

suggest searchingCreditInfo edit to "查詢學分資訊中..." or "查詢學分資訊..."

@ntut-xuan
Copy link
Collaborator Author

intl_zh_TW.arb

suggest searchingCreditInfo edit to "查詢學分資訊中..." or "查詢學分資訊..."

Will create another PR.

@ntut-xuan ntut-xuan merged commit ef45e69 into master Mar 1, 2024
4 checks passed
@ntut-xuan ntut-xuan deleted the hotfix/twice_loading_student_list branch March 1, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants