Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:image): added nzNoReset flag (#7689) #7702

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eyudinkov
Copy link

@eyudinkov eyudinkov commented Oct 28, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7689
close: #7689

What is the new behavior?

Added a new flag nzNoReset to NzImagePreviewOptions, which allows not to reset image options to defaults during the navigation

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #7702 (ba58c0d) into master (41b56e4) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #7702      +/-   ##
==========================================
- Coverage   92.02%   92.01%   -0.01%     
==========================================
  Files         502      502              
  Lines       16759    16764       +5     
  Branches     2636     2639       +3     
==========================================
+ Hits        15422    15425       +3     
- Misses       1069     1071       +2     
  Partials      268      268              
Impacted Files Coverage Δ
components/image/image-preview.component.ts 93.71% <83.33%> (-0.49%) ⬇️
components/image/image-preview-options.ts 100.00% <100.00%> (ø)
...ts/table/src/table/table-inner-scroll.component.ts 79.41% <0.00%> (-4.42%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eyudinkov
Copy link
Author

Seems like I've added enough tests, but CI doesn't pass because of the table-inner-scroll component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NzImagePreviewOptions get reset on next() and prev()
1 participant