Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:table): use nzCustomColumn to hide columns without using width and flex css property #8891

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sharakouze
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

I don't like the way nzCustomColumn works actually because it forces me to provide a width for those columns.
I just want to hide some columns, without defining width and without using flex css property.

Issue Number: N/A

What is the new behavior?

I've done this using the nzCustomColumn property but if you prefer I can do this by creating a new property (nzHiddenColumns for example)
If you set "hidden" property instead of "default" in nzCustomColumn, the NzCustomColumnDirective will just set display: none for cells you want to be hidden

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Nov 22, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.90%. Comparing base (eb1fdc5) to head (be5694b).
Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
...mponents/table/src/cell/custom-column.directive.ts 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8891      +/-   ##
==========================================
+ Coverage   91.89%   91.90%   +0.01%     
==========================================
  Files         546      555       +9     
  Lines       19291    19712     +421     
  Branches     2850     2946      +96     
==========================================
+ Hits        17728    18117     +389     
- Misses       1251     1267      +16     
- Partials      312      328      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery
Copy link
Collaborator

Laffery commented Nov 23, 2024

@OriginRing Please take a look

@sharakouze
Copy link
Contributor Author

@OriginRing > any news ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants