cleaning up nocomp patch indexing #1226
Open
Task list completed / task-list-completed
Started
2025-01-09 16:56:27
ago
0 / 4 tasks completed
4 tasks still to be completed
Details
Required Tasks
| Task | Status |
|---|---|
| The in-code documentation has been updated with descriptive comments | Incomplete |
| The documentation has been assessed to determine if updates are necessary | Incomplete |
| FATES PASS/FAIL regression tests were run | Incomplete |
| Evaluation of test results for answer changes was performed and results provided | Incomplete |
| Technical Note update: | Incomplete |
| User's Guide update: | Incomplete |
| Instead of iterating a patch number index while looping patches, we now always use the patch%patchno to get a boundary condition index for our bc_in and bc_out arrays. | Incomplete |
| We no longer filter nocomp patches based on patchno == 0, and instead compared if the patch's nocomp_pft_label equals nocomp_bareground. | Incomplete |
| There was an inconsistency in how we calculated vegetation temperatures. Originally I thought this inconsistency was causing issues related to nocomp bareground patches, where those patches had uninitialized temperatures. After investigation, those patches appear to have vegetation temperatures initialized from air temperature. So these changes are not as much of a bug fix related to the other changes, and may be more appropriate stand-alone as an improvement. See this diff: 36a86e6 | Incomplete |
Loading