Changed search system to keyset-based #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoRosendo
force-pushed
the
feature/keysetSearch
branch
3 times, most recently
from
e2d8862 to
2b4dfd3
Compare
Naapperas
previously approved these changes
Mar 6, 2022
imnotteixeira
requested changes
Mar 6, 2022
BrunoRosendo
force-pushed
the
feature/keysetSearch
branch
from
2b4dfd3 to
f218dc4
Compare
BrunoRosendo
force-pushed
the
feature/keysetSearch
branch
from
29b433f to
abb04e7
Compare
Merged
imnotteixeira
requested changes
Mar 19, 2022
|
@BrunoRosendo please update the route function, the comment is outdated here https://github.com/NIAEFEUP/nijobs-be/blob/develop/src/api/routes/offer.js#L22-L25 also, we should rename the variable, since the new .get function no longer returns offers only (also the token now) https://github.com/NIAEFEUP/nijobs-be/blob/develop/src/api/routes/offer.js#L28 |
BrunoRosendo
force-pushed
the
feature/keysetSearch
branch
from
76717d7 to
91accbb
Compare
NIJobs Launch
Fix wrong nijobs email in email templates
Fix edit not working when offer is hidden
|
@BrunoRosendo NIAEFEUP/nijobs-fe#172 is ready, is this also ready? When we merge these, we need to do it at the same time. |
Yes, let's merge them! |
BrunoRosendo
force-pushed
the
feature/keysetSearch
branch
from
91accbb to
7477941
Compare
|
@imnotteixeira Could you please re-review? I can't request it, I'm not sure why |
imnotteixeira
requested changes
May 20, 2022
imnotteixeira
requested changes
May 21, 2022
imnotteixeira
requested changes
May 22, 2022
BrunoRosendo
force-pushed
the
feature/keysetSearch
branch
from
129f8e0 to
a2751ae
Compare
imnotteixeira
previously approved these changes
May 24, 2022
TiagooGomess
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #129
The new package base64url is capable of encoding a token in a way that's safe to write in a URL