added parameter definitions for phytoplankton growth + cleanup #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliestock
added
documentation
yichengt900
reviewed
Sep 3, 2024
yichengt900
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
@charliestock, thanks for this PR adding detailed parameter definitions. I only fixed a small typo; everything else looks good to me. We will address the remaining parameters and the unit conversion issue in a separate PR. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds parameter definitions and cleans up the units for the phytoplankton growth parameters in COBALTv3. It covers about 25% of the parameter definitions. It should not change answers. It would be good, however, to revisit our discussion of the units for parameter inputs. I think it works OK for parameters like alpha - the initial slope of the photosynthesis-irradiance curve - and rate parameters since these do not have explicit units in the variable names. I'm a bit concerned, however, about parameters like "fe_2_n". Entering values as fe_2_c and then converting them may create confusion. We can discuss this further at the next doc&dev meeting, along with a few other odds and ends.