Skip to content

Commit

Permalink
Update several units in CCPP metadata following CCPP framework update (
Browse files Browse the repository at this point in the history
…#422)

* Replace units 'various' with 'mixed', update several invalid units of non-physical quantities, fix units of humidity diagnostic variables
* Change units of relative humidity variables in CCPP metadata from 1 or none to frac, remove intent attributes from GFS_typedefs.meta
  • Loading branch information
climbfuji authored Nov 23, 2021
1 parent 9df46a8 commit c72ba60
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 21 deletions.
2 changes: 1 addition & 1 deletion ccpp/data/CCPP_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
[pkz]
standard_name = finite_volume_mean_edge_pressure_raised_to_the_power_of_kappa
long_name = finite-volume mean edge pressure raised to the power of kappa
units = Pa**kappa
units = 1
dimensions = (starting_x_direction_index:ending_x_direction_index,starting_y_direction_index:ending_y_direction_index,1:vertical_dimension_for_fast_physics)
type = real
kind = kind_dyn
Expand Down
34 changes: 16 additions & 18 deletions ccpp/data/GFS_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@
[hprime]
standard_name = statistical_measures_of_subgrid_orography_collection_array
long_name = orographic metrics
units = various
units = mixed
dimensions = (horizontal_loop_extent,number_of_statistical_measures_of_subgrid_orography)
type = real
kind = kind_phys
Expand Down Expand Up @@ -3247,7 +3247,7 @@
[mg_qcvar]
standard_name = relative_variance_of_subgrid_cloud_condensate_distribution
long_name = cloud water relative variance for MG microphysics
units =
units = frac
dimensions = ()
type = real
kind = kind_phys
Expand All @@ -3261,7 +3261,7 @@
[mg_rhmini]
standard_name = relative_humidity_threshold_for_ice_nucleation
long_name = relative humidity threshold parameter for nucleating ice for MG microphysics
units = none
units = frac
dimensions = ()
type = real
kind = kind_phys
Expand Down Expand Up @@ -3512,14 +3512,12 @@
units = flag
dimensions = ()
type = logical
intent = in
[decfl]
standard_name = deformed_CFL_factor
long_name = deformed CFL factor
units = count
dimensions = ()
type = integer
intent = in
[lgfdlmprad]
standard_name = flag_for_GFDL_microphysics_radiation_interaction
long_name = flag for GFDL microphysics-radiation interaction
Expand Down Expand Up @@ -3812,7 +3810,7 @@
[rhgrd]
standard_name = relative_humidity_threshold_for_condensation
long_name = relative humidity threshold parameter for condensation for FA scheme
units = none
units = frac
dimensions = ()
type = real
kind = kind_phys
Expand Down Expand Up @@ -5728,21 +5726,21 @@
[tau_amf]
standard_name = absolute_momentum_flux_due_to_nonorographic_gravity_wave_drag
long_name = ngw_absolute_momentum_flux
units = various
units = mixed
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[ozpl]
standard_name = ozone_forcing
long_name = ozone forcing data
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_dimension_of_ozone_forcing_data,number_of_coefficients_in_ozone_forcing_data)
type = real
kind = kind_phys
[h2opl]
standard_name = stratospheric_water_vapor_forcing
long_name = water forcing data
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_dimension_of_h2o_forcing_data,number_of_coefficients_in_h2o_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -6333,7 +6331,7 @@
[fluxr]
standard_name = cumulative_radiation_diagnostic
long_name = time-accumulated 2D radiation-related diagnostic fields
units = various
units = mixed
dimensions = (horizontal_loop_extent,number_of_diagnostics_variables_for_radiation)
type = real
kind = kind_phys
Expand Down Expand Up @@ -6914,7 +6912,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down Expand Up @@ -6950,14 +6948,14 @@
[rh02max]
standard_name = maximum_relative_humidity_at_2m_over_maximum_hourly_time_interval
long_name = maximum relative humidity at 2m over maximum hourly time interval
units = %
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[rh02min]
standard_name = minimum_relative_humidity_at_2m_over_maximum_hourly_time_interval
long_name = minumum relative humidity at 2m over maximum hourly time interval
units = %
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
Expand Down Expand Up @@ -8179,7 +8177,7 @@
[faerlw]
standard_name = aerosol_optical_properties_for_longwave_bands_01_16
long_name = aerosol optical properties for longwave bands 01-16
units = various
units = mixed
dimensions = (horizontal_loop_extent,adjusted_vertical_layer_dimension_for_radiation,number_of_aerosol_bands_for_longwave_radiation,number_of_aerosol_output_fields_for_longwave_radiation)
type = real
kind = kind_phys
Expand Down Expand Up @@ -8207,7 +8205,7 @@
[faersw]
standard_name = aerosol_optical_properties_for_shortwave_bands_01_16
long_name = aerosol optical properties for shortwave bands 01-16
units = various
units = mixed
dimensions = (horizontal_loop_extent,adjusted_vertical_layer_dimension_for_radiation,number_of_aerosol_bands_for_shortwave_radiation,number_of_aerosol_output_fields_for_shortwave_radiation)
type = real
kind = kind_phys
Expand Down Expand Up @@ -9813,7 +9811,7 @@
[q_lay]
standard_name = water_vapor_mixing_ratio
long_name = water vaport mixing ratio
units = kg/kg
units = kg kg-1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
Expand Down Expand Up @@ -9975,7 +9973,7 @@
[aerosolslw]
standard_name = RRTMGP_aerosol_optical_properties_for_longwave_bands_01_16
long_name = aerosol optical properties for longwave bands 01-16
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension, number_of_longwave_bands,number_of_aerosol_output_fields_for_longwave_radiation)
type = real
kind = kind_phys
Expand Down Expand Up @@ -10004,7 +10002,7 @@
[aerosolssw]
standard_name = RRTMGP_aerosol_optical_properties_for_shortwave_bands_01_16
long_name = aerosol optical properties for shortwave bands 01-16
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension, number_of_shortwave_bands, number_of_aerosol_output_fields_for_shortwave_radiation)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion ccpp/framework
Submodule framework updated 79 files
+1 −0 .github/workflows/python.yaml
+3 −3 .travis.yml
+1 −1 CODEOWNERS
+6 −6 doc/HelloWorld/hello_scheme.meta
+2 −2 doc/HelloWorld/hello_world_host.meta
+6 −6 doc/HelloWorld/temp_adjust.meta
+84 −190 scripts/ccpp_capgen.py
+16 −101 scripts/ccpp_datafile.py
+9 −6 scripts/ccpp_fortran_to_metadata.py
+1 −1 scripts/ccpp_prebuild.py
+238 −1,997 scripts/ccpp_suite.py
+6 −2 scripts/code_block.py
+1 −1 scripts/common.py
+156 −72 scripts/constituents.py
+1 −1 scripts/conversion_tools/unit_conversion.py
+45 −34 scripts/ddt_library.py
+2 −2 scripts/file_utils.py
+13 −15 scripts/fortran_tools/fortran_write.py
+63 −28 scripts/fortran_tools/parse_fortran.py
+65 −66 scripts/fortran_tools/parse_fortran_file.py
+385 −0 scripts/framework_env.py
+41 −26 scripts/host_cap.py
+39 −31 scripts/host_model.py
+1 −1 scripts/metadata2html.py
+8 −2 scripts/metadata_parser.py
+73 −54 scripts/metadata_table.py
+252 −659 scripts/metavar.py
+1 −1 scripts/mkcap.py
+1 −1 scripts/mkdoc.py
+1 −1 scripts/mkstatic.py
+2 −0 scripts/parse_tools/__init__.py
+24 −12 scripts/parse_tools/parse_checkers.py
+1 −1 scripts/parse_tools/parse_log.py
+7 −2 scripts/parse_tools/parse_object.py
+6 −2 scripts/parse_tools/parse_source.py
+6 −2 scripts/parse_tools/preprocess.py
+123 −3 scripts/parse_tools/xml_tools.py
+8 −3 scripts/state_machine.py
+1,912 −0 scripts/suite_objects.py
+1,294 −0 scripts/var_props.py
+190 −164 src/ccpp_constituent_prop_mod.F90
+4 −4 test/advection_test/cld_ice.meta
+4 −4 test/advection_test/cld_liq.meta
+3 −3 test/advection_test/run_test
+5 −2 test/advection_test/test_host.F90
+9 −2 test/advection_test/test_host.meta
+1 −1 test/advection_test/test_host_data.meta
+8 −3 test/advection_test/test_reports.py
+6 −6 test/capgen_test/environ_conditions.meta
+6 −6 test/capgen_test/make_ddt.meta
+5 −5 test/capgen_test/run_test
+4 −2 test/capgen_test/temp_adjust.F90
+6 −6 test/capgen_test/temp_adjust.meta
+6 −6 test/capgen_test/temp_calc_adjust.meta
+8 −8 test/capgen_test/temp_set.meta
+7 −4 test/capgen_test/test_host.F90
+9 −2 test/capgen_test/test_host.meta
+1 −1 test/capgen_test/test_host_data.meta
+9 −4 test/capgen_test/test_reports.py
+6 −0 test/run_doctest.sh
+62 −0 test/run_tests.sh
+2 −2 test/unit_tests/sample_files/test_host.meta
+6 −6 test/unit_tests/sample_files/test_multi_ccpp_arg_tables.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPeq1_var_in_fort_meta.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPeq1_var_missing_in_fort.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPeq1_var_missing_in_meta.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPgt1_var_in_fort_meta.meta
+2 −2 test/unit_tests/sample_scheme_files/CCPPnotset_var_missing_in_meta.meta
+2 −2 test/unit_tests/sample_scheme_files/invalid_dummy_arg.meta
+2 −2 test/unit_tests/sample_scheme_files/invalid_subr_stmnt.meta
+6 −6 test/unit_tests/sample_scheme_files/mismatch_intent.meta
+4 −4 test/unit_tests/sample_scheme_files/missing_arg_table.meta
+6 −6 test/unit_tests/sample_scheme_files/missing_fort_header.meta
+6 −6 test/unit_tests/sample_scheme_files/reorder.meta
+6 −6 test/unit_tests/sample_scheme_files/temp_adjust.meta
+38 −31 test/unit_tests/test_metadata_scheme_file.py
+65 −68 test/unit_tests/test_metadata_table.py
+424 −0 test/unit_tests/test_var_transforms.py
+7 −3 tests/test_metadata_parser.py
2 changes: 1 addition & 1 deletion ccpp/physics

0 comments on commit c72ba60

Please sign in to comment.