Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement spatially varying decay rates for internal tides leakage #794

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

raphaeldussin
Copy link

This allows to change the decay time for different latitudes, tidal harmonic and vertical mode, like is done in Fig 4 of
de Lavergne 2019

@Hallberg-NOAA Hallberg-NOAA self-assigned this Jan 6, 2025
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking better, but now there is a variable description that no longer works. Please revise this description, perhaps as suggested in the specific comment. Once this is done, I think that this will be good to go.

@Hallberg-NOAA
Copy link
Member

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26041.

@Hallberg-NOAA Hallberg-NOAA merged commit 585d24d into NOAA-GFDL:dev/gfdl Jan 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants