Fix new EventPort bug #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear - 428
The "new" Event Portfolio format had a bug. The result include "single values" and "geo distribution" for the (only singular) "raw" field. For Criteria that are build from more than one field, the needs to be data for more than one "raw" results. This new(er) Event Portfolio format can handle multiple field Criteria. During the reformatting, some unnecessary repetition in the structure was identified and some there is some reformatting to nest both "single values" and "geo distribution" within the same structure.
The easiest place to see the changes to the schema is changes to the example messages at the top of test_validate_schema.py