chore: IDSSE-441: PublishConfirm internal cleanup #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Issue
Changes
None
-check around any usage of self._connection or self._channelconnection
arg that pika passes to our callbacks to avoid using the private variable at all.PublishConfirm.start()
more than onceAlso a minor addition to
rabbitmq_utils
:connection_parameters
property toConn
data object.parameters
to any type of pika connection, and is less limited thanConn.to_connection()
which is only useful for making a BlockingConnection.