-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix* emissions reporting #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed merge conflicts with the column definitions.csv.
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed and fixed merge conflicts in the column definition csv.
The merge-base changed after approval.
8126a50
to
7443147
Compare
# Conflicts: # postprocessing/comstockpostproc/resources/comstock_column_definitions.csv
results.csv,emissions_reporting.annual_electricity_ghg_emissions_egrid_2021_state_kg,out.emissions.electricity.egrid_2021_state,TRUE,FALSE,float,co2e_kg,co2e_kg,"annual greenhouse gas emissions from electricity use, using egrid 2021 state emissions intensity" | ||
results.csv,emissions_reporting.annual_electricity_ghg_emissions_egrid_2021_subregion_kg,out.emissions.electricity.egrid_2021_subregion,TRUE,FALSE,float,co2e_kg,co2e_kg,"annual greenhouse gas emissions from electricity use, using egrid 2021 subregion emissions intensity" | ||
results.csv,emissions_reporting.winter_daily_average_electricity_ghg_emissions_egrid_2021_state_kg,out.emissions.electricity.winter_daily_average.egrid_2021_state,TRUE,FALSE,float,co2e_kg,co2e_kg,"winter daily average greenhouse gas emissions from electricity use, using egrid 2021 state intensity" | ||
results.csv,emissions_reporting.winter_daily_average_electricity_ghg_emissions_egrid_2021_subregion_kg,out.emissions.electricity.winter_daily_average.egrid_2021_subregion,TRUE,FALSE,float,co2e_kg,co2e_kg,"winter daily average greenhouse gas emissions from electricity use, using egrid 2021 subregion intensity" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eringold I noticed you deleted these "daily_average" emissions entries. They were added specifically for the emission objective lighting measure recently. Could we add them back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JieXiong9119 this was my mistake, I missed those in the conflict resolution in this file. I can make a PR can fix tomorrow or Thurs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! FYI, I believe there are 15 rows with substring daily_average_electricity_ghg_emission
.
Pull request overview
*Not quite a fix to #220 pending EnergyPlus version update. Until we upgrade to >24.2, the 'out.emissions.electricity.enduse_group.hvac.*' columns will be zero for almost all models. However, the 'calc.weighted.enduse_group.electricity.hvac.emissions.egrid_2021_subregion' column is still calculated in postprocessing from HVAC energy and total electricty emissions instead of the enduse_group as reported in the measure.
Once we use EnergyPlus with the fixed custom meters, we can use the reported HVAC emissions directly to calculate weighted enduse_group emissions.
This PR:
prefer='threads'
fixes it.Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File