Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

301-2022 Addendum E (CFIS systems), part 1 #741

Merged
merged 15 commits into from
Oct 16, 2024
Merged

301-2022 Addendum E (CFIS systems), part 1 #741

merged 15 commits into from
Oct 16, 2024

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Aug 28, 2024 •
edited
Loading

Pull Request Description

  • Breaking change: Removes VentilationOnlyModeAirflowFraction input for CFIS systems (blower fan assumed to run at max flow rate during ventilation only operation).
  • Breaking change: Removes FanPower/FanPowerDefaulted inputs for CFIS systems (fan power assumed to be HVAC's FanPowerWattsPerCFM multiplied by the blower fan max flow rate).
  • Allows modeling CFIS systems with no strategy to meet remainder of ventilation target (CFISControls/AdditionalRuntimeOperatingMode="none").

Checklist

Not all may apply:

  • OS-HPXML git subtree has been pulled
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., rulesets\tests and/or workflow/tests/*_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results on CI

@shorowit shorowit self-assigned this Aug 28, 2024
@shorowit
Fix docs [ci skip]
1cdea24
@shorowit
Merge branch 'latest-os-hpxml' of https://github.com/NREL/OpenStudio-ERI
ca5ed48 
 into cfis_addendum_e

# Conflicts:
#	Changelog.md
#	workflow/tests/base_results/real_homes.csv
#	workflow/tests/base_results/sample_files.csv
@shorowit
Squashed 'hpxml-measures/' changes from 9bb1ac4ba6..1ae00d2c40
f5d3c4d 
1ae00d2c40 Implement CFIS fan power defaulting.
86f4b722e2 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cfis_continued
d65c8a35f5 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cfis_continued
2c92a20750 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cfis_continued
e4fbc89a97 Update expected simulation results
b26f7748d4 A few more fixes.
ba1239ddf0 Address CI failures
28f8c4047a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cfis_continued
f98754ece3 Clean up docs/schematron related to CFIS FanPower and VentilationOnlyModeAirflowFraction inputs.

git-subtree-dir: hpxml-measures
git-subtree-split: 1ae00d2c406797d3880d3a0b2e464b4ca7a9be6a
@shorowit
Merge commit 'f5d3c4d8bf1b3a530365ef5a79824bec7750c791' into cfis_add…
77545d0 
…endum_e
@shorowit
Remove CFIS fan power input; uses the blower fan W/cfm multiplied by …
a609339 
…the air handler's maximum airflow rate.
@shorowit shorowit changed the title 301-2022 Addendum E (CFIS systems) 301-2022 Addendum E (CFIS systems), part 1 Oct 14, 2024
@shorowit shorowit marked this pull request as ready for review October 16, 2024 16:55
@shorowit shorowit merged commit 8be673a into latest-os-hpxml Oct 16, 2024
@shorowit shorowit deleted the cfis_addendum_e branch October 16, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shorowit