Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ventilation system bugfix #763

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Ventilation system bugfix #763

merged 3 commits into from
Jan 9, 2025

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Jan 9, 2025 •
edited
Loading

Pull Request Description

Fixes possibility of extra balanced supplemental ventilation system due to floating point comparison.

Checklist

Not all may apply:

  • OS-HPXML git subtree has been pulled
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., rulesets\tests and/or workflow/tests/*_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results on CI

@shorowit shorowit added the bug label Jan 9, 2025
@shorowit shorowit self-assigned this Jan 9, 2025
shorowit added a commit that referenced this pull request Jan 9, 2025
@shorowit
Backport #763
9d70fb9
@shorowit shorowit marked this pull request as ready for review January 9, 2025 18:28
@shorowit shorowit merged commit e3ccbb7 into master Jan 9, 2025
@shorowit shorowit deleted the ventfan_floating_point branch January 9, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shorowit