Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializes nrcan_446 branch: skylights & wells #1854

Open
wants to merge 11 commits into
base: nrcan
Choose a base branch
from
+612 −719
Open

Initializes nrcan_446 branch: skylights & wells #1854

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2a4ed9b
Initializes nrcan_446 branch: skylights & wells
brgix Nov 25, 2024
9dd78b6
Comments out (broken) 'setConstruction' call
brgix Dec 6, 2024
4fad85d
Initial implementation + unit test
brgix Dec 9, 2024
64536f3
BTAP pre-1980 tweaks + gem spec tweaks
brgix Dec 10, 2024
32cb6f1
Fixes skylight gross area tally
brgix Dec 11, 2024
cfc5d71
Fixes SmallOffice roof overhang area bug
brgix Dec 11, 2024
4f72316
Reduces gra0 vs graX equations
brgix Jan 14, 2025
e60c1e1
Merge pull request #1874 from NREL/nrcan
ckirney Jan 14, 2025
68e3f30
Reintroduce uprated Uo assignment
brgix Jan 15, 2025
6691d2c
Cleanup + full unit TBD tests
brgix Jan 16, 2025
5b32f37
Merge pull request #1881 from NREL/nrcan
brgix Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/openstudio-standards/btap/bridging.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,7 +1502,8 @@ def initialize(model = nil, argh = {})
next unless construction[:stypes ] == stypes
next if construction[:surfaces].empty?

# construction[:surfaces].values.each { |surface| surface.setConstruction(construction[:uo]) }
BTAP::Geometry::Surfaces.set_surfaces_construction_conductance(construction[:surfaces].values, construction[:uo])
# construction[:surfaces].values.each { |surface| surface.setConstruction(construction[:uo]) }
Copy link
Collaborator Author

@brgix brgix Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reintroducing the BTAP::Geometry::Surfaces.set_surfaces_construction_conductance call. This had changed about a year ago with this commit. However, the change couldn't have worked given that construction[:uo] is simply a U-factor (in W/K.m2). Reverting to the original solution for now.

TBD doesn't need to have uprated, clear-field U-factors reset for constructions this way. At the time, keeping track (within the BTAP-generated OSM) of the uprated construction U-factors was deemed useful for documentation/costing purposes. This can be achieved otherwise within BTAP. Other changes are expected over the next weeks, given the upcoming structure/construction changes to BTAP. So this may change.

Note that this is unrelated to skylight wells, and the change should be introduced under a new (or another existing) pull request. TODO.

end
end

Expand Down