Airloop naming convention change. #1856
Open
+19,990
−17,425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the HVAC system naming conventions in the NECB2011 module to include additional options for air source heat pumps with different supplemental fuels. - Modified the 'sys_htg' parameter in the system name parameters to include 'ashp>c-g' for air source heat pumps with natural gas as the supplemental fuel and 'ashp>c-e' for air source heat pumps with electricity as the supplemental fuel. - Made the necessary changes in the 'hvac_system_4.rb', 'hvac_system_1_single_speed.rb', 'hvac_systems.rb', and 'hvac_system_3_and_8_single_speed.rb' files.
Including boiler fuel type and capacity ratio changes, SHW fuel type changes, and changes from master.
Update from nrcan branch
Updates from nrcan to support VSCode and NREL Docker images
Merging changes from nrcan_434
…ethod in NECB2011/hvac_system_6.rb as it did not add sys6 to all the zones that need, causing errors in unit tests of NV and DCV ECMs
…umOffice 2011, 2017, 2020 for both NaturalGas and Electricity as they did not have required airloops as the nrcan branch
if a hot water loop is needed.
Including fix to missing system 6 air loops
…sts on s3 as same tests, including unit tests for NV and DCV ECMS, that pass locally, fail on s3
loop is needed when forcing HVAC system types.
Tweak a comment in test_dcv.rb just for the sake of re-running all te…
…old system.json but renamed and not used.
Update code to determine if HW loop is required for a Heating system. Removing support for TPFC systems for cooling only until code supports it.
Fixing type in boiler_fueltype parameter in noair baseboard ECM.
…elling units to the list of other spaces if any non-default HVAC systems are defined for them. Essentially, washrooms, cooridors, storage spaces and dwelling units will either have default HVAC systems assigned to them or ones defined by the other spaces.
…ors system types are defined they use the primary system type instead (or are defaluted if no primary is defined). Making HVAC system descriptions unique.
… systems.json table. Updating the systems_including_sys5.json table to distinguish between sys3 and sys4 descriptions.
…dined system types to zones.
incorporating this when setting the system 2 heating coil type. setting sys2 heating coil type to supplemental fuel type when DX. Will handle properly in future.
cooling tower associated with a specific chiller is modified rather than assuming that only one cooling tower is in the model. Also, ensuring that wet spaces are removed when setting the 'other space types' HVAC systems.
determining if a hot water loop is required.
… user execpt when setting to hvac_system_primary. Updating cut-off to autosize cooling tower fans to 600W.
Pulling additional fixes when setting the system type
Update from nrcan branch
Including HS15 CASHP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)requirestatements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.