Run nvidia-smi after installing the nv-drivers #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
requested review from
elezar,
tariq1890 and
cdesiniotis
as code owners
elezar
reviewed
Jan 22, 2025
| @@ -35,6 +35,8 @@ sudo dpkg -i cuda-keyring_1.1-1_all.deb | |||
|
|
|||
| with_retry 3 10s sudo apt-get update | |||
| install_packages_with_retry cuda-drivers | |||
|
|
|||
| with_retry 3 10s nvidia-smi -L | |||
There was a problem hiding this comment.
you are right, not needed, edited
There was a problem hiding this comment.
If there's a chance that the previous step exits before the driver is ready a retry may make sense. What does the driver container do?
There was a problem hiding this comment.
if a step fails, it fails fast so that this new line won't be run.
The driver container has this steps to load the modules -> https://github.com/NVIDIA/gpu-driver-container/blob/main/ubuntu24.04/nvidia-driver#L222
maybe is something worth replicating here
There was a problem hiding this comment.
OK. Let's keep this as is and update if required later.
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
elezar
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.