Simplify standalone installer #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
use-logger-in-toolkit-install
branch
from
2d685f7 to
dbed2e9
Compare
|
I've pulled out the addition of tests to #768. I would rather merge those first. |
elezar
force-pushed
the
use-logger-in-toolkit-install
branch
from
dbed2e9 to
a71dcc2
Compare
elezar
force-pushed
the
use-logger-in-toolkit-install
branch
from
a71dcc2 to
2a5d5c4
Compare
elezar
force-pushed
the
use-logger-in-toolkit-install
branch
3 times, most recently
from
255d550 to
ba98e64
Compare
This is not (currently) a supported installation mechanism. |
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
This change moves the containerized installer from nvidia-toolkit to cmd/nvidia-ctk-installer to allow for its use in CI. Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
use-logger-in-toolkit-install
branch
from
ba98e64 to
6bd292e
Compare
ArangoGutierrez
approved these changes
Jan 21, 2025
OddBloke
added a commit
to wolfi-dev/os
that referenced
this pull request
Jan 23, 2025
Upstream have integrated these into the main build since 1.16.x: * NVIDIA/nvidia-container-toolkit#722 * NVIDIA/nvidia-container-toolkit#765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts refactoring the toolkit installation process from the toolkit contianer.
The changes are non-functional and limited to:
The goal is to gradually move towards allowing #602 to be used for a single container image.