Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automated commits to NangoHQ/nango for use-cases.json and flows.yaml #146

Closed
wants to merge 32 commits into from

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Dec 10, 2024

Describe your changes

Update flow sync script to also generate and sync use-cases.json. Also updates commit message to add some newlines to it.

I'll only have this run on main and fix the push target to only be master on the nango repo once this is reviewed and approved.

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set
  • I followed the best practices and guidelines from the Writing Integration Scripts doc

@nalanj nalanj self-assigned this Dec 10, 2024
Copy link

linear bot commented Dec 10, 2024

@nalanj nalanj marked this pull request as draft December 10, 2024 16:59
@nalanj
Copy link
Contributor Author

nalanj commented Dec 11, 2024

The sync test above is failing because I deleted the branch it was running against. It's easy enough to re-enable but I was trying to keep it from running here.

@nalanj nalanj marked this pull request as ready for review December 11, 2024 19:12
@nalanj nalanj closed this Dec 11, 2024
@nalanj nalanj deleted the alan/nan-2320/automate-use-cases branch December 11, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants