feat(ui): create environment UI #3280
Conversation
| @@ -22,7 +22,7 @@ export const connectionIdSchema = z | |||
| .max(255); | |||
| export const envSchema = z | |||
| .string() | |||
| .regex(/^[a-zA-Z0-9_-]+$/) | |||
| .regex(/^[a-z0-9_-]+$/) | |||
There was a problem hiding this comment.
It was an oversight, prod has no env with an uppercase
There was a problem hiding this comment.
Works great! Lots of small comments below that should in no-way block this:
- One silly issue we may want to handle is overflows on the environment name. This would apply in the scrolling list as well. See:
- It may also make sense to put an overflow scroll on the list in the dropdown so that the button always shows:
-
Maybe just a future issue, but should we let you rename an environment from the Environment Settings UI?
-
Also should we handle deleting environments? No clue how awful that would be but someone's going to ask for it once they can easily create them.
|
|
||
| const environments = await environmentService.getEnvironmentsByAccountId(accountId); | ||
| if (environments.length >= 10) { | ||
| res.status(400).send({ error: { code: 'resource_capped', message: "Can't create more environment" } }); |
There was a problem hiding this comment.
| res.status(400).send({ error: { code: 'resource_capped', message: "Can't create more environment" } }); | |
| res.status(400).send({ error: { code: 'resource_capped', message: "Can't create more environments" } }); |
|
Thanks, fixed that scroll issue and fixed width 
Not planned yet
Not planned yet Since it's for paying customer they will still have a direct line of contact with us, butI'm sure those 2 features will come later 👌🏻 |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 8205899 | Triggered | Generic Password | 0b2906f | packages/cli/docker/docker-compose.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Changes
Fixes https://linear.app/nango/issue/NAN-2224/create-environments-in-nango-ui
Add UI to create environment
As stated by the spec, it's only available for paying customers and up to 10 env.
Fix Dropdown checkbox
Fix some error check
🧪 Tests