fix(fleet): image override might contain the commitId tag #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Jan 10, 2025
| }: { | ||
| type: 'CREATE'; | ||
| routingId: Node['routingId']; | ||
| deployment: Deployment; | ||
| nodeConfig?: NodeConfig | undefined; |
There was a problem hiding this comment.
unrelated to this change but it was not used anymore
the entire point of image override in fleet is to be able to create a node running a specific commit (for pre-deployment testing or verification purpose) This commit ensures that an image override with a commitId tag is properly handled
TBonnin
force-pushed
the
tbonnin/fleet-image-override
branch
from
04226ea to
0920c68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the entire point of image override in fleet is to be able to create a node running a specific commit (for pre-deployment testing or verification purpose) This commit ensures that an image override with a commitId tag is properly handled
tested in staging