feat(server): Enrich webhook errors #3319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
reviewed
Jan 16, 2025
bodinsamuel
reviewed
Jan 16, 2025
|
@bodinsamuel handled deliver errors in a36990b |
bodinsamuel
approved these changes
Jan 17, 2025
| if (response.status >= 200 && response.status < 300) { | ||
| await logCtx.info( | ||
| await logCtx.http( | ||
| `${webhookType} webhook sent successfully to the ${type} ${url} and received with a ${response.status} response code${endingMessage ? ` ${endingMessage}` : ''}.`, |
There was a problem hiding this comment.
message for HTTP log should be METHOD URL (yes it's not good everywhere :D)
bodinsamuel
reviewed
Jan 17, 2025
| @@ -134,6 +134,7 @@ export interface MessageRow { | |||
| response: { | |||
| code: number; | |||
| headers: Record<string, string>; | |||
| body?: unknown; | |||
There was a problem hiding this comment.
Just had a thought before going to bed, you need to add this prop to schema.ts as keyword "index": false and "doc_values": false otherwise it will blow up
bodinsamuel
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enriches webhook errors with much more information about the request that was made, to help customers with debugging.
Of course they should log these requests themselves, but there are certainly also cases like gateway errors where they wouldn't receive these and it could be good to see the full request from our side:
In that screenshot above, I fixed this small bug:
How I tested it: