Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/core - Enhance async module exception handling to prevent core from crashing under module failure #26

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

glrs
Copy link
Collaborator

@glrs glrs commented Nov 29, 2024

This pull request includes several changes to improve error handling and task management in the ygg-mule.py and ygg_trunk.py files. The most important changes are the introduction of a new asynchronous function for launching realms and enhanced exception handling in the process_couchdb_changes function.

Improvements in error handling and task management:

  • ygg-mule.py: Added a new asynchronous function launch_realm to handle the launching of realms with proper error handling. Updated the process_document function to use this new function. [1] [2]
  • ygg_trunk.py: Enhanced the process_couchdb_changes function to gather task results with return_exceptions=True and log any exceptions that occur. This ensures that all exceptions are properly logged and handled. [1] [2]

@glrs glrs changed the title Feature/core - Enhance async module exception handling to prevent core from crashing in module failure Feature/core - Enhance async module exception handling to prevent core from crashing under module failure Nov 29, 2024
@glrs glrs merged commit 1033855 into NationalGenomicsInfrastructure:main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant