Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert sample extraction logic to exclude aborted samples and simplif… #35

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

glrs
Copy link
Collaborator

@glrs glrs commented Jan 15, 2025

This pull request includes changes to the lib/realms/smartseq3 module to improve the handling of samples, specifically excluding aborted samples from processing. The most important changes are the removal of the aborted sample handling logic and the update to the sample extraction process.

Improvements to sample handling:

  • lib/realms/smartseq3/ss3_project.py: Updated the extract_samples method to exclude aborted samples entirely from the list of SS3Sample instances. Added logging to indicate when a sample is skipped due to being aborted. [1] [2]

Code simplification:

@glrs glrs merged commit e5d098a into NationalGenomicsInfrastructure:main Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant