Revert sample extraction logic to exclude aborted samples and simplif… #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
lib/realms/smartseq3
module to improve the handling of samples, specifically excluding aborted samples from processing. The most important changes are the removal of the aborted sample handling logic and the update to the sample extraction process.Improvements to sample handling:
lib/realms/smartseq3/ss3_project.py
: Updated theextract_samples
method to exclude aborted samples entirely from the list ofSS3Sample
instances. Added logging to indicate when a sample is skipped due to being aborted. [1] [2]Code simplification:
lib/realms/smartseq3/ss3_sample.py
: Removed theaborted
parameter from theSS3Sample
constructor and the associated logic that set the sample status to "aborted". [1] [2]