Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'process' method to 'launch' across core and realms #8

Conversation

glrs
Copy link
Collaborator

@glrs glrs commented Oct 29, 2024

This pull request focuses on renaming the process method to launch across different project classes and scripts. This renaming aims to reflect the method's purpose better, improve code clarity, and avoid confusion with the sample's class process method. Also, remove the pre_process methods since they have not been used and have fallen out of scope.

Method renaming:

  • lib/base/abstract_project.py: Renamed the process method to launch in the abstract base class and updated the docstring to reflect the new method name.
  • lib/realms/smartseq3/smartseq3.py: Renamed the process method to launch and updated the corresponding docstring. Removed the pre_process method as it was no longer needed. [1] [2]
  • lib/realms/tenx/tenx_project.py: Renamed the process method to launch and updated the corresponding docstring. Removed the pre_process method as it was no longer needed.

Script updates:

  • ygg-mule.py: Updated the call from realm.process() to realm.launch() to align with the method renaming.
  • ygg_trunk.py: Updated the call from realm.process() to realm.launch() to align with the method renaming.

@glrs glrs merged commit da1dc8c into NationalGenomicsInfrastructure:main Oct 29, 2024
3 checks passed
@glrs glrs deleted the refactor/rename-process-to-launch branch October 29, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant